Add FeatureEnabled expression, schema metadata, and publish under @flippercloud scope - #10
Merged
Conversation
Add a FeatureEnabled expression (schema + valid/invalid examples) that returns true when the named feature is enabled for the current actor, and register it in schema.json. Add category metadata (Condition/Value) to several schemas and a reusable property definition. Bump to 1.1.0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Document that changes to schemas/ or examples/ require re-running `rake expressions:vendor` and the schema spec in flippercloud/flipper. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The property definition was an unreferenced alias of constant ("Property
Value" -> constant). Reading a property is already handled by the Property
function, and nothing in the schemas referenced this definition. Remove it
until a consumer exists.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Rename the npm package from @flippercloud.io/expressions (a personal user scope) to @flippercloud/expressions, the org we control alongside @flippercloud/flipper and friends. Also fix the repository URL (typo'd https:: and pointing at the old monorepo). Schema $id URLs keep www.flippercloud.io — those are the canonical schema identifiers tied to the website domain and the Ruby gem's BaseURI, not the npm scope. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jnunemaker
changed the title
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FeatureEnabled, which returns true when the named feature is enabled for the current actor. Includes the schema (schemas/FeatureEnabled.schema.json), valid/invalid examples (examples/FeatureEnabled.json), and registration inschemas/schema.json.category(Condition/Value) to several schemas and a description toPercentageOfActors.@flippercloud.io/expressions(a personal user scope) to@flippercloud/expressions(the org we control, alongside@flippercloud/flipper). Fixes the brokenrepositoryURL. Schema$idURLs keepwww.flippercloud.io— those are canonical schema identifiers tied to the website domain and the Ruby gem'sBaseURI, not the npm scope.CLAUDE.mddocumenting that schema/example changes must be re-synced into the flipper gem viarake expressions:vendor.Test plan
FeatureEnabledexamples)standardlint cleannpm run buildsucceeds;npm publish --dry-runresolves to@flippercloud/expressions@1.1.0🤖 Generated with Claude Code