bugfixes for haversine formula - #10
Open
pdtyreus wants to merge 2 commits into
Open
Conversation
added 2 commits
August 7, 2015 14:50
I found some issues with this implementation while testing. You can reproduce by holding the longitude constant and varying the latitude. The formula in the current implementation always returns 0 for the distance.
```objective-c
float refLat = 24.396308f;
float refLng = -124.848974f;
ZFHaversine *haversine = [[ZFHaversine alloc] initWithLatitude1:refLat longitude1:refLng latitude2:38.896376f longitude2:refLng];
float yKm = [haversine kilos];
haversine = [[ZFHaversine alloc] initWithLatitude1:refLat longitude1:refLng latitude2:refLat longitude2:-77.328688f];
float xKm = [haversine kilos];
haversine = [[ZFHaversine alloc] initWithLatitude1:refLat longitude1:refLng latitude2:38.896376f longitude2:-77.328688f];
float km = [haversine kilos];
NSLog(@"translate %f %f %f",yKm,xKm,km);
```
I updated the formula based on the wikipedia version https://en.wikipedia.org/wiki/Haversine_formula.
I assume since this has been untouched for a couple years the implementation provided is working fine for your use. But I figured I would offer to contribute back since I found the code handy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found some issues with this implementation while testing. You can reproduce by holding the longitude constant and varying the latitude. The formula in the current implementation always returns 0 for the distance.
I updated the formula based on the wikipedia version https://en.wikipedia.org/wiki/Haversine_formula.
I assume since this has been untouched for a couple years the implementation provided is working fine for your use. But I figured I would offer to contribute back since I found the code handy.