Guard against malformed UTF16 environment variables or command line arguments#53
Merged
Merged
Conversation
…rguments This doesn't quite match Apple behaviour - on there we still construct NSString instances with malformed data, but that's liable to cause a crash or unexpected behaviour elsewhere, like when converting to UTF8. Instead, silently skip adding these to the environment block. If there's malformed data in there, we likely don't want to use it anyways.
stegru
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't quite match Apple behaviour - on there we still construct NSString instances with malformed data, but that's liable to cause a crash or unexpected behaviour elsewhere, like when converting to UTF8.
Instead, silently skip adding these to the environment block. If there's malformed data in there, we likely don't want to use it anyways.