Repository navigation
Release v0.0.13 - #32
Merged
Merged
Conversation
…beds TransactionFilter::queryForInternal eager loads line items, the journal with its debit and credit accounts, and the subject/payer/payee/ initiator/context morphs inside the cached list query, so edits to any of them were served stale until the cache expired. Declare them as $apiCacheDependencies so core-api's list cache key carries their versions: the relation paths, plus the morph target tables ledger writes (ledger_invoices, contacts, vendors, companies). Orders and drivers are left out because they are written constantly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 1253 1253
===========================================
Files 74 74
Lines 6990 6990
===========================================
Hits 6990 6990
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ic API The customer invoice routes (ledger/public/...) ran no middleware, so paying an invoice was never written to the API request logs. They now run LogApiRequests. The public wallet API (ledger/v1/...) already runs it through fleetbase.api and is logged once core-api logs every route that opts in (fleetbase/core-api#302). Webhooks and internal routes stay unlogged. The route registrar test stub now records each route's group middleware.
fix(transactions): declare the tables the cached transactions list embeds
feat(api-logs): log writes to the public invoice routes like the public API
RouteRegistrar::group() takes only the callback. Passing the attributes array as its first argument made Router::group() treat the array as a routes file, which fails with 'Array to string conversion' while the routes load and takes the whole API down. The Postman contract job hit it on release/v0.0.13.
Fixes to a release branch were only verified once the release PR itself re-ran, because every workflow listed main alone. Match core-api, which already runs on dev-v* and release/v* targets.
The bootstrap's RouteRegistrar only learned middleware from a group() attributes array, which is the Router form; the registrar's own middleware() call was missing, so the routes file could not be loaded in the test once it used it.
fix(routes): attach the public invoice middleware through the registrar
chore(deps): ember-ui 0.4.6 and ember-core 0.3.26
…engine's dependencies
docs(release): name the core-api release the fixes ship with and the engine's dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release branch for v0.0.13, cut from
main.This branch collects #33, the fix for stale transaction lists. It declares the tables the cached transactions list embeds (line items, journals, accounts, invoices and the payer/payee party tables), so edits to them invalidate the list.
Before merging
The fix takes effect with fleetbase/core-api's cache dependency support (fleetbase/core-api#301). It is inert with an older core-api, so this release can merge independently.
Merging this into
mainreleases v0.0.13 (composer.json,package.jsonandextension.jsonare bumped, andRELEASE.mdis updated).