[roncodes]

Follow-up to #408 for fleetbase/fleetbase#723. Stacked on #408: this branch contains its commit, so merge #408 first. After that, this diff shrinks to this PR's own two commits.

Problem

#408 fixed the internal geocoder/query and geocoder/reverse endpoints. Every other caller of the geocoder-laravel facade had the same bug. The facade builds its Google provider from config/geocoder.php when the config loads, which is before the settings-table API key is set. Its Chain provider then swallows the failure, so the lookup returns nothing:

• Place::createFromGeocodingLookup, getValuesFromGeocodingLookup, createFromCoordinates, insertFromCoordinates
• PlaceSearch::geocode (the plain-text fallback branch)
• Api\v1\PlaceController::geocodeAddress (address-only place creation)
• Api\v1\DriverController (locality and country on driver tracking)

Change

• New helpers Geocoding::lookupAddress() and Geocoding::lookupCoordinates() use Geocoding::geocoder() with GeocodeQuery::create / ReverseQuery::fromCoordinates and return collect(...->all()), so callers get the same shape as before. A failed lookup still resolves to an empty collection, matching what the facade did. That keeps place creation's raw-address / (0, 0) fallback from turning into a 500 on installs without a Google key. The failure is now logged as a warning instead of hidden.
• DriverController calls Geocoding::geocoder() directly. Its existing try/catch still reports geocoder failures to Sentry.
• No facade usage remains in server/src.

config/geocoder.php

I fixed this file rather than deleting it. Removing it would make the facade fall back to the package's default config, which adds a GeoPlugin provider. Code outside fleetops may still resolve app('geocoder').

• The first GoogleMaps argument is the region, but the file passed the locale. It now passes env('GOOGLE_MAPS_REGION').
• The cache store was 'geocode', which is not defined anywhere. It is now null, the default store.
• Neither setting affects fleetops anymore.

Tests

• Test stand-ins now bind fleetops.geocoder (geocodeQuery / reverseQuery / all) instead of app('geocoder'). The Geocoder::clearResolvedInstances() calls are gone.
• New tests cover the failure paths that lost coverage once every test injected fleetops.geocoder: building the live Google geocoder, Geocoding::query() rethrowing, the import raw-address fallback, and PlaceSearch's outer guard. The full suite passes locally with the 100% coverage gate.
• Two tests depended on the keyless geocoder throwing because fleetops.geocoder was unbound. They now bind a geocoder that throws on purpose.
• New test: lookupAddress / lookupCoordinates return raw addresses, log failures and return empty results, and createFromGeocodingLookup keeps its raw-address fallback.
• Each touched test file passes on its own with php scripts/pest-runner.php --debug <file> (exit 0). php-cs-fixer is clean.

Follow-up outside this repo

storefront's ServiceQuoteControllerContractsTest and OrderEditorApplyCoverageTest bind app('geocoder') stand-ins for fleetops place creation. They should move to fleetops.geocoder too.

Refs fleetbase/fleetbase#723

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7887aa5) to head (64cc345).
⚠️ Report is 1 commits behind head on release/v0.6.74.

Additional details and impacted files

@@                 Coverage Diff                 @@
##             release/v0.6.74      #409   +/-   ##
===================================================
  Coverage             100.00%   100.00%           
- Complexity             13591     13596    +5     
===================================================
  Files                    634       634           
  Lines                  49331     49342   +11     
===================================================
+ Hits                   49331     49342   +11     

Flag	Coverage Δ
backend	100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.