Skip to content

fix(descriptors): open Fleet-Ops records on their page outside Fleet-Ops - #88

Merged
roncodes merged 1 commit into
release/v0.2.3from
fix/open-outside-engine
Oct 12, 2026
Merged

roncodes merged 1 commit into
release/v0.2.3from
fix/open-outside-engine

Conversation

@roncodes

Copy link
Copy Markdown
Member

What changed

engineOpener (the open used by the shared driver, vehicle, contact, customer, place, order, vendor and fleet descriptors) now opens a record's context panel only while the console is on the owning engine's routes. Anywhere else it uses the action service's transition.view, so the record opens on its Fleet-Ops page.

Why

Fleet-Ops action services open panels with component names (vehicle/panel-header, tab components). The <ResourceContextPanel /> that renders the panel is the one in the current engine. From Storefront that is Storefront's, so the names do not resolve there and rendering throws:

Attempted to resolve `vehicle/panel-header`, which was expected to be a component, but nothing was found.

Resolving the component class from the Fleet-Ops engine instance does not help either: the header's own template then fails on Fleet-Ops helpers (placeholder-image), because loose-mode templates resolve against the rendering engine. Opening the record's page is the reliable path. It is what Storefront's "Open vehicle" button already does.

Details

  • New isInsideEngine(manager, engineName) compares the console's current route to the engine mount point from extensionManager.getEngineMountPoint. When it cannot tell (no manager, no route, no mount point) it answers yes, which keeps the previous behaviour.
  • Mode semantics are unchanged: transition always transitions, and an unknown mode still opens nothing.

Validation

  • npx ember test --filter resource-descriptors: 34 tests pass. New tests cover the panel inside Fleet-Ops, the page from Storefront, a panel-only service outside the engine, and isInsideEngine, including the prefix trap console.fleet-ops-reports.
  • In the console: clicking a vehicle from Storefront's trucks page now lands on /fleet-ops/manage/vehicles/<id> with the vehicle panel open, where it used to throw.

No API or docs impact.

… opens its Fleet-Ops page instead of a panel whose components only Fleet-Ops can render
@codecov

codecov Bot commented Oct 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 99.96%. Comparing base (423f108) to head (3e1e0db).

Files with missing lines Patch % Lines
addon/utils/resource-descriptors/helpers.js 90.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (90.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (99.96%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/v0.2.3      #88      +/-   ##
==================================================
- Coverage          100.00%   99.96%   -0.04%     
==================================================
  Files                 121      121              
  Lines                3148     3157       +9     
  Branches              773      777       +4     
==================================================
+ Hits                 3148     3156       +8     
- Misses                  0        1       +1     
Flag Coverage Δ
fleetops-data 99.96% <90.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
addon/utils/resource-descriptors/helpers.js 98.92% <90.00%> (-1.08%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 423f108...3e1e0db. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@roncodes
roncodes merged commit e6b5315 into release/v0.2.3 Oct 12, 2026
2 of 5 checks passed
@roncodes
roncodes deleted the fix/open-outside-engine branch October 12, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant