Skip to content

Fix TIFF writer bug (beta) #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Unrud merged 1 commit into from
May 28, 2022
Merged

Fix TIFF writer bug (beta) #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions com.github._4lex4.ScanTailor-Advanced.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ modules:
path: com.github._4lex4.ScanTailor-Advanced.metainfo.xml.in
- type: patch
path: scantailor-qt5.15.patch
- type: patch
path: scantailor-tiffsave-fix.patch
buildsystem: cmake-ninja
builddir: true
config-opts:
Expand Down
23 changes: 23 additions & 0 deletions scantailor-tiffsave-fix.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
commit 5ee818e03f2201e34e3707151133dee3f2e43de9
Author: Hubert Figuière <hub@figuiere.net>
Date: Tue Jan 5 15:23:48 2021 -0500

Issue #164 - Fix TIFF saving when JPEG and posterized

diff --git a/src/core/TiffWriter.cpp b/src/core/TiffWriter.cpp
index f68b021..385c4ec 100644
--- a/src/core/TiffWriter.cpp
+++ b/src/core/TiffWriter.cpp
@@ -225,8 +225,10 @@ bool TiffWriter::writeBitonalOrIndexed8Image(const TiffHandle& tif, const QImage
}

if (image.format() == QImage::Format_Indexed8) {
- TIFFSetField(tif.handle(), TIFFTAG_COMPRESSION,
- uint16(ApplicationSettings::getInstance().getTiffColorCompression()));
+ uint16 compress = (photometric == PHOTOMETRIC_PALETTE) ?
+ COMPRESSION_LZW :
+ uint16(ApplicationSettings::getInstance().getTiffColorCompression());
+ TIFFSetField(tif.handle(), TIFFTAG_COMPRESSION, compress);
} else {
TIFFSetField(tif.handle(), TIFFTAG_COMPRESSION, uint16(ApplicationSettings::getInstance().getTiffBwCompression()));
}