Skip to content

Fix TIFF writer bug - #3

Merged
Unrud merged 1 commit into
flathub:masterfrom
hfiguiere:tiff-issue-164
May 28, 2022
Merged

Fix TIFF writer bug#3
Unrud merged 1 commit into
flathub:masterfrom
hfiguiere:tiff-issue-164

Conversation

@hfiguiere

@hfiguiere hfiguiere commented May 28, 2022

Copy link
Copy Markdown
Contributor

This is a patch I submitted upstream 4lex4/scantailor-advanced#166 a while ago, but upstream is unresponsive.

It doesn't apply on the EA branch (for beta), but I can port it there. (see #4)

This cause some images to not be generated as indexed colours isn't supported with JPEG, so in that case the patch reverts to LZW compression.

@flathubbot

Copy link
Copy Markdown

Started test build 93632

@flathubbot

Copy link
Copy Markdown

Build 93632 failed

@Unrud
Unrud merged commit 6ac57b1 into flathub:master May 28, 2022
@Unrud

Unrud commented May 28, 2022

Copy link
Copy Markdown
Collaborator

Thank you

@hfiguiere

Copy link
Copy Markdown
Contributor Author

you merged a failed build.

@hfiguiere
hfiguiere deleted the tiff-issue-164 branch May 28, 2022 23:35
@hfiguiere

hfiguiere commented May 28, 2022

Copy link
Copy Markdown
Contributor Author

yeah I did mess my branches when regenerating patches, and didn't rebuilt. Anyway I see that you fixed it, but that wasn't my intent to submit a broken PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants