kola/coretest: directly test update_engine DBus interface - #931
Draft
amanmaurya92 wants to merge 1 commit into
Draft
kola/coretest: directly test update_engine DBus interface#931amanmaurya92 wants to merge 1 commit into
amanmaurya92 wants to merge 1 commit into
Conversation
This resolves a FIXME in TestUpdateEngine by replacing the CLI wrapper execution with a direct gdbus call to the org.chromium.UpdateEngine DBus system interface. This natively verifies that the update_engine daemon is alive, attached to the system bus, and capable of responding to RPC calls, which matches how external controllers integrate with the service. Signed-off-by: amanmaurya92 <amanmaurya9209@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves a
FIXMEinTestUpdateEngineby replacing the CLI wrapper execution with a directgdbuscall to theorg.chromium.UpdateEngineDBus system interface.This natively verifies that the
update_enginedaemon is alive, successfully attached to the system bus, and capable of responding to RPC calls, which matches exactly how external controllers (like Kubernetes reboot agents) integrate with the service.How to use
Reviewers can validate this PR by running the internet-dependent tests and ensuring the
UpdateEnginestep successfully completes over the DBus interface:Testing done
Executed
$env:GOOS="linux"; cd kola/tests/coretest; go buildto syntactically verify the package logic and ensure no compilation regressions occurred in the modified goroutine.changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.