wip: Oracle Cloud support#871
Conversation
3e045be to
d48af83
Compare
Signed-off-by: Navaneeth <me@rizexor.com>
d48af83 to
367367a
Compare
|
private ipv4 & public ip is not exposed via afterburn in Oracle which is required for some tests. So I need to add it upstream. For now I will use systemd hack. Correct me if I am mistaken. @tormath1 https://github.com/coreos/afterburn/blob/main/docs/usage/attributes.md#metadata-attributes |
Signed-off-by: Navaneeth <me@rizexor.com>
|
I think my PR is ready. Let me know what else to implement. |
tormath1
left a comment
There was a problem hiding this comment.
Thanks a lot, overally it looks good. I just have one request, usually the ore command is used to create and upload an image on the cloud provider. Is that possible to implement this?
It's then used like that: https://github.com/flatcar/scripts/blob/d2c217cb741debc9becda0bda86347319f17a65c/ci-automation/vendor-testing/stackit.sh#L24-L48
We first upload the image then we use the resulting image ID in the kola run command.
| return nil, fmt.Errorf("launching instance: %w", err) | ||
| } | ||
|
|
||
| instance, err := a.WaitForInstanceState(ctx, *resp.Instance.Id, core.InstanceLifecycleStateRunning) |
There was a problem hiding this comment.
It seems that the Go SDK has a Retry mechanism, that would be interesting to use it: https://pkg.go.dev/github.com/oracle/oci-go-sdk/v65#hdr-Retry
Mantle has its own Retry function as well:
$ go doc util.Retry
package util // import "github.com/flatcar/mantle/util"
func Retry(attempts int, delay time.Duration, f func() error) error
Retry calls function f until it has been called attemps times, or succeeds.
Retry delays for delay between calls of f. If f does not succeed after
attempts calls, the error from the last call is returned.
Signed-off-by: Navaneeth <me@rizexor.com>
Signed-off-by: Navaneeth <me@rizexor.com>
Signed-off-by: Navaneeth <me@rizexor.com>
|
Done, tested ore image uploads. Added retry also, using
|
Adds Oracle Cloud Testing Support
Adds Oracle Cloud Testing Support.