Skip to content

chore(cli): regen against go-flashduty — add session-delete, drop console-only skill-download#61

Merged
ysyneu merged 2 commits into
feat/ai-srefrom
feat/cli-session-delete
Jun 24, 2026
Merged

chore(cli): regen against go-flashduty — add session-delete, drop console-only skill-download#61
ysyneu merged 2 commits into
feat/ai-srefrom
feat/cli-session-delete

Conversation

@ysyneu

@ysyneu ysyneu commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Why

Follow-up to go-flashduty #14 (merged): bump the SDK to the synced spec and regenerate the cli.

What

  • adds fduty safari session-delete (POST /safari/session/delete) — previously a public op with no SDK/cli command.
  • drops fduty safari skill-download/safari/skill/download was reclassified auth=all → jwt (console-only application/zip download used only by the Customize UI via session cookie; fc-pgy #570, flashduty-docs #106). It's no longer a public op. The old command was a broken, unused generated artifact — the SDK method (*string) couldn't decode a zip.
  • session.go: Sessions.List → Sessions.ReadList (the hand-written /insight list helper), following the SDK's read/write method rename.
  • regenerated zz_generated_* reflect the SDK type refresh (TimestampMilli, pointer scalars) and the a2a / mcp operationId renames.

Verification

go build ./... clean; full go test ./... green (incl. the internal/cli coverage invariant TestEveryOperationHasPathCommand — every public op reachable at its path-name — and TestGeneratorTargetsFullSpec: 251/251 non-streaming generated, 1 streaming (session-export) curated). gofmt/gci clean.

Note: a local make check lint step errors with "golangci-lint (built with go1.24) lower than targeted go1.25.1" — a pre-existing toolchain-pin mismatch (the go 1.25.1 directive is identical on the base; my change doesn't touch it), not a code issue.

ysyneu added 2 commits June 24, 2026 22:34
…ill-download)

Bump go-flashduty to the merged spec-sync commit (go-flashduty #14) and
regenerate cligen.

- adds `fduty safari session-delete` (POST /safari/session/delete) — was a
  public op with no cli command.
- drops `fduty safari skill-download` — /safari/skill/download was reclassified
  jwt (console-only application/zip download; fc-pgy #570, flashduty-docs #106)
  and is no longer a public op. The old command was a broken, unused generated
  artifact (the SDK method couldn't decode a zip).
- session.go: Sessions.List -> Sessions.ReadList (hand-written /insight list
  helper) following the SDK's read/write method rename.
- regenerated zz_generated_* reflect the SDK type refresh (TimestampMilli,
  pointer scalars) and the a2a/mcp operationId renames.

Build + full test suite green; the "every public op reachable" coverage
invariant passes (251/251 non-streaming generated, session-export the only
curated streaming op).
The go-flashduty bump adds the channel escalate-webhook-robot-list command
(the cli was 8 days behind). Regenerate the channel skill card's GENERATED
fence so `skilldoc check` (check-cards CI) stays green.
@ysyneu ysyneu merged commit 814a217 into feat/ai-sre Jun 24, 2026
12 checks passed
@ysyneu ysyneu deleted the feat/cli-session-delete branch June 24, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant