fix(api): add missing return statements after RespondError - #797
Open
AruneshDwivedi wants to merge 1 commit into
Open
fix(api): add missing return statements after RespondError#797AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
…etHeader Two error paths in handleGetHeader called RespondError without returning, allowing execution to continue with potentially nil values and cause a panic or incorrect response. Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #779
In handleGetHeader, two error paths called RespondError without returning, allowing execution to continue with potentially nil values from bid.Value() and bid.BlockHash(). This could cause a panic or incorrect response.
The fix adds the missing return statements after each RespondError call.