test(kunlunxin): add generic IPC memory handle validation#516
Open
yangchaoss wants to merge 3 commits into
Open
test(kunlunxin): add generic IPC memory handle validation#516yangchaoss wants to merge 3 commits into
yangchaoss wants to merge 3 commits into
Conversation
yangchaoss
requested review from
MC952-arch,
aoyulong and
mikethegoblin
as code owners
July 16, 2026 13:21
MC952-arch
reviewed
Jul 21, 2026
| #include "flagcx.h" | ||
| #include "topo.h" | ||
|
|
||
| #ifdef USE_KUNLUNXIN_ADAPTOR |
Collaborator
There was a problem hiding this comment.
Better to not introduce branch compilation in unittest
Author
There was a problem hiding this comment.
Done. Removed the KunlunXin-specific compile guards and private-header
dependency from the adaptor tests. IPC handles are now managed through
the public adaptor APIs, and unsupported backends are skipped at runtime.
The changes were also rebased onto FlagCX v0.13.0 (0beba7a).
yangchaoss
force-pushed
the
feat/kunlunxin-ipc-memory-handle
branch
from
July 22, 2026 13:17
9ae4ee0 to
4228e79
Compare
MC952-arch
reviewed
Jul 24, 2026
| MPI_OBJS := $(MPI_SRCS:%.cpp=$(OBJDIR)/%.o) | ||
| MPI_TARGET := $(BINDIR)/adaptor_mpi_tests | ||
| MPIRUN ?= mpirun | ||
| MPI_NP ?= 2 |
Keep the IPC memory handle test explicitly two-rank and show the command needed to run it with the required process count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
PAL (Portable Abstraction Layer)
PR Types
Test Case
PR Description
This PR adds generic IPC memory handle validation for the device adaptor,
based on FlagCX v0.13.0 (
0beba7aa).Changes:
ipcMemHandleCreateimplementation.ipcMemHandleCreate,ipcMemHandleGet, andipcMemHandleClose.dependencies from the adaptor tests.
Create -> Get -> transfer -> Open -> data validation -> Close -> Free.Validation:
git diff --checkpassed.Notes:
both ranks on the same host and does not support cross-node handle transfer.
not runtime-tested in this environment; unsupported IPC implementations
are skipped at runtime.
DeviceAdaptorTest.StreamWaitEventstill fails in the full adaptor suitein this environment and is not modified by this PR.