Release 2026-05-22 16:44:42 +0000#9943
Merged
Merged
Conversation
Contributor
|
@komagata build_and_test が失敗していたため調査したところ、 bootcamp/test/fixtures/events.yml Lines 184 to 193 in f8649fa 現在は「主催イベントも表示する」仕様になっているため、 そのため、 bootcamp/test/system/user/events_test.rb Line 21 in f8649fa という期待値と fixture の状態が矛盾しているように見えました。
修正方針が比較的明確で小さい変更のため、先に self assign の上で PR 作成まで進めておこうと思います。 問題ありそうでしたら止めますので、ご確認いただけますと助かります。 |
Member
|
@koguchi-e ありがとうございます。別PRでお願いできればありがたいです。 |
Contributor
Mentor::BuzzesController#edit/update/delete作成 metnor/buzzes/_form.html.slimのurlフィールドをeditページに非表示 mentor/buzzes/edid.html.slimに削除ボタンを追加
いずれもmentor_buzzes_pathへ修正
title, url, published_atカラムにそれぞれ追加
提出物レビューでGitHubリンク先コードを参照する
GitHubリンク確認用の提出物seedを追加する
提出物レビューのピヨルド人格を共通化する
YouTubeのリンクカード取得をoEmbedで補完
提出物詳細のSlim-Lint指摘を修正する
…-icon Ctrl + i キーのショートカットをアイコン(:@自分:)が出るように変更
…tutions Review App cleanupのsubstitutionsを修正
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.