Skip to content

Release 2026-05-22 16:44:42 +0000#9943

Merged
komagata merged 477 commits into
productionfrom
main
May 23, 2026
Merged

Release 2026-05-22 16:44:42 +0000#9943
komagata merged 477 commits into
productionfrom
main

Conversation

@github-actions

@github-actions github-actions Bot commented Apr 23, 2026

Copy link
Copy Markdown

@github-actions github-actions Bot changed the title Preparing release pull request... Release 2026-04-23 07:45:42 +0000 Apr 23, 2026
@github-actions github-actions Bot changed the title Release 2026-04-23 07:45:42 +0000 Release 2026-04-23 07:47:35 +0000 Apr 23, 2026
@github-actions github-actions Bot changed the title Release 2026-04-23 07:47:35 +0000 Release 2026-04-24 11:33:58 +0000 Apr 24, 2026
@github-actions github-actions Bot changed the title Release 2026-04-24 11:33:58 +0000 Release 2026-04-27 13:05:04 +0000 Apr 27, 2026
@github-actions github-actions Bot changed the title Release 2026-04-27 13:05:04 +0000 Release 2026-04-27 18:26:03 +0000 Apr 27, 2026
@github-actions github-actions Bot changed the title Release 2026-04-27 18:26:03 +0000 Release 2026-04-28 01:35:06 +0000 Apr 28, 2026
@github-actions github-actions Bot changed the title Release 2026-04-28 01:35:06 +0000 Release 2026-04-28 02:28:11 +0000 Apr 28, 2026
@github-actions github-actions Bot changed the title Release 2026-04-28 02:28:11 +0000 Release 2026-04-28 03:50:42 +0000 Apr 28, 2026
@github-actions github-actions Bot changed the title Release 2026-04-28 03:50:42 +0000 Release 2026-04-30 07:44:30 +0000 Apr 30, 2026
@github-actions github-actions Bot changed the title Release 2026-04-30 07:44:30 +0000 Release 2026-05-01 15:55:05 +0000 May 1, 2026
@github-actions github-actions Bot changed the title Release 2026-05-01 15:55:05 +0000 Release 2026-05-01 16:10:44 +0000 May 1, 2026
@github-actions github-actions Bot changed the title Release 2026-05-01 16:10:44 +0000 Release 2026-05-01 17:55:14 +0000 May 1, 2026
@github-actions github-actions Bot changed the title Release 2026-05-01 17:55:14 +0000 Release 2026-05-08 03:00:03 +0000 May 8, 2026
@github-actions github-actions Bot changed the title Release 2026-05-08 03:00:03 +0000 Release 2026-05-08 07:08:17 +0000 May 8, 2026
@github-actions github-actions Bot changed the title Release 2026-05-08 07:08:17 +0000 Release 2026-05-08 07:09:23 +0000 May 8, 2026
@koguchi-e

koguchi-e commented May 12, 2026

Copy link
Copy Markdown
Contributor

@komagata
お疲れ様です。

build_and_test が失敗していたため調査したところ、test/system/user/events_test.rb の以下 fixture が原因ではないかと考えています。

event34:
title: "未来のイベント(未参加)"
description: "未来のイベント(未参加)"
location: "FJORDオフィス"
capacity: 40
start_at: 2024-03-26 10:00
end_at: 2024-03-26 12:00
open_start_at: 2024-02-26 10:00
open_end_at: 2024-03-26 09:00
user: kimura

現在は「主催イベントも表示する」仕様になっているため、kimura が主催者になっているこのイベントは、未参加でも一覧に表示される状態になっています。

そのため、

assert_no_text '未来のイベント(未参加)'

という期待値と fixture の状態が矛盾しているように見えました。

user を別ユーザー(例: komagata)へ変更し、「未参加かつ主催でもないイベント」に修正するのが自然かなと考えていますが、こちらの方向で問題ないでしょうか?

修正方針が比較的明確で小さい変更のため、先に self assign の上で PR 作成まで進めておこうと思います。

問題ありそうでしたら止めますので、ご確認いただけますと助かります。

@github-actions github-actions Bot changed the title Release 2026-05-08 07:09:23 +0000 Release 2026-05-12 03:30:16 +0000 May 12, 2026
@github-actions github-actions Bot changed the title Release 2026-05-12 03:30:16 +0000 Release 2026-05-12 06:26:43 +0000 May 12, 2026
@komagata

Copy link
Copy Markdown
Member

@koguchi-e ありがとうございます。別PRでお願いできればありがたいです。

@github-actions github-actions Bot changed the title Release 2026-05-12 06:26:43 +0000 Release 2026-05-12 18:39:14 +0000 May 12, 2026
@koguchi-e

Copy link
Copy Markdown
Contributor

@komagata
#9990 にてPR作成しました~!
現在、生徒間レビューを依頼済です!

@github-actions github-actions Bot changed the title Release 2026-05-21 10:22:49 +0000 Release 2026-05-22 04:41:45 +0000 May 22, 2026
@github-actions github-actions Bot changed the title Release 2026-05-22 04:41:45 +0000 Release 2026-05-22 05:16:55 +0000 May 22, 2026
@github-actions github-actions Bot changed the title Release 2026-05-22 05:16:55 +0000 Release 2026-05-22 07:25:50 +0000 May 22, 2026
@github-actions github-actions Bot changed the title Release 2026-05-22 07:25:50 +0000 Release 2026-05-22 08:18:12 +0000 May 22, 2026
@github-actions github-actions Bot changed the title Release 2026-05-22 08:18:12 +0000 Release 2026-05-22 08:24:22 +0000 May 22, 2026
@github-actions github-actions Bot changed the title Release 2026-05-22 08:24:22 +0000 Release 2026-05-22 08:58:28 +0000 May 22, 2026
@github-actions github-actions Bot changed the title Release 2026-05-22 08:58:28 +0000 Release 2026-05-22 08:58:31 +0000 May 22, 2026
komagata added 2 commits May 22, 2026 19:20
…-icon

Ctrl + i キーのショートカットをアイコン(:@自分:)が出るように変更
@github-actions github-actions Bot changed the title Release 2026-05-22 08:58:31 +0000 Release 2026-05-22 12:31:27 +0000 May 22, 2026
…tutions

Review App cleanupのsubstitutionsを修正
@github-actions github-actions Bot changed the title Release 2026-05-22 12:31:27 +0000 Release 2026-05-22 16:44:42 +0000 May 22, 2026
@komagata komagata merged commit 94d2f99 into production May 23, 2026
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants