画像からExifが削除されないバグの修正

app/models/image.rb

@@ -4,23 +4,10 @@ class Image < ApplicationRecord
   belongs_to :user
   has_one_attached :image
 
-  after_commit :strip_exif, on: :create
+  validates :image, attached: true
 
-  private
-
-  def strip_exif
-    original_image = image
-    copied_image = MiniMagick::Image.read(original_image.download)
-    copied_image.strip
-
-    ext = File.extname(original_image.filename.to_s)
-    timestamp = Time.current.strftime('%Y%m%d%H%M%S%L')
-    File.open(copied_image.path) do |file|
-      original_image.attach(io: file, filename: "#{user.id}_#{timestamp}#{ext}")
-    end
-  rescue StandardError => e
-    Rails.logger.error("Failed to strip EXIF: #{e.message}")
-  ensure
-    copied_image&.destroy!
+  def image=(attachable)
+    MiniMagick::Image.new(attachable.tempfile.path).strip if attachable.respond_to?(:tempfile)
+    super
   end
 end

test/integration/api/image_test.rb

@@ -20,9 +20,14 @@ class API::ImageTest < ActionDispatch::IntegrationTest
     post api_image_path(format: :json), params: { file: image_uploaded }
     assert_response :created
 
-    saved_image = Image.order(:created_at).last
-    processed_image = MiniMagick::Image.read(saved_image.image.download)
+    saved_image = Image.last
+
+    api_response = JSON.parse(response.body)
+    returned_url = api_response['url']
+    expected_blob = saved_image.image.blob
+    assert_includes(returned_url, expected_blob.signed_id)
 
+    processed_image = MiniMagick::Image.read(saved_image.image.download)
     assert_empty processed_image.exif
   end
 end

test/models/image_test.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+class ImageTest < ActiveSupport::TestCase
+  test 'remove exif data when image is updated' do
+    image_path = Rails.root.join('test/fixtures/files/articles/ogp_images/test.jpg')
+    image = Image.create!(user: users(:hajime), image: Rack::Test::UploadedFile.new(image_path, 'image/jpeg'))
+
+    image.update!(image: Rack::Test::UploadedFile.new(image_path, 'image/jpeg'))
+
+    updated_image = MiniMagick::Image.read(image.image.download)
+    assert_empty updated_image.exif
+  end
+end