Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/models/link_checker/checker.rb
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ def valid_domain?(domain)

Resolv.getaddress(domain)
true
rescue Resolv::ResolvError
rescue Resolv::ResolvError => e
Rails.logger.info("[LinkChecker] #{e.class}: domain=#{domain}") unless Rails.env.production?
false
end

Expand Down
12 changes: 10 additions & 2 deletions app/models/metadata.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,22 @@ def fetch
http.response_body_encoding = true

response = http.request_get(@uri.request_uri)
response.message == 'OK' ? parse(response.body) : nil
if response.message != 'OK'
Rails.logger.info("[Metadata] Response was not OK: status=#{response.code} url=#{@url}") unless Rails.env.production?
return
end
Comment thread
coderabbitai[bot] marked this conversation as resolved.

parse(response.body)
end

private

def parse(html)
object = OpenGraphReader.parse(html)
return unless object
unless object
Rails.logger.info("[Metadata] OpenGraphReader parse failed: url=#{@url}, title=#{Nokogiri::HTML(html).title}") unless Rails.env.production?
return
end

{
title: object.og.title,
Expand Down
Loading