fix: make enabling/disabling E2E encryption non-destructive - #141
Merged
Conversation
Several sharp edges from the encryption PR: - Disabling now decrypts every note and rewrites it as plaintext (with a confirm) before dropping the salt, instead of orphaning the ciphertext. - Enabling backfills existing plaintext notes so "Enabled" really covers them; the existing title is passed through so metadata isn't regenerated from ciphertext. - The locked-out unlock dialog gets a "Forgot your passphrase?" reset so a forgotten passphrase no longer bricks the whole app. - Salt POST returns the effective stored salt, so a double-setup can't derive a key against a salt the server never kept. - bytesToBase64 chunks the spread to avoid a RangeError on large notes. update() skips title/summary regeneration when a title is passed, which the backfill/rewrite loops rely on. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update()skips title/summary regeneration when a title is explicitly passed (used by the backfill/rewrite loops).Test plan
enc:…server-side; UI still readable