Repository navigation
Fix MRR reactivation/new classification and refund fan-out in line_item_enhanced - #162
Open
porkedchop wants to merge 1 commit into
Open
porkedchop wants to merge 1 commit into
porkedchop wants to merge 1 commit into
Conversation
…ication in the MRR report
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #161
Please provide your name and company
Bishop Kammeraad
Describe what this PR changes and how it addresses the linked issue or feature request.
stripe__subscription_item_mrr_report: adds the MRR from two and three months back and whether the item has had MRR before, classifiesnewas the first month with MRR and checksreactivation(three months at zero) ahead ofexpansion. The final select lists the documented columns so the helper columns stay internal.stripe__line_item_enhanced: sums refunds and their balance transaction fee per charge in therefundCTE, the same way discounts are summed per invoice, and drops the separate refund balance transaction join.These change output values, so I left the version and CHANGELOG for you.
How did you validate the changes introduced within this PR, and what warehouse did you use for testing?
DuckDB. Built the integration tests project with the extra rows described in #161 and compared before and after: the paused item's June becomes
reactivation, the trial item's first paid month becomesnew, the refunded invoice goes from 4 line rows to 2 withrefund_amount500, and every other row is unchanged.dbt buildpasses.