Repository navigation
Convert screen and view time from milliseconds to seconds - #55
Open
porkedchop wants to merge 1 commit into
Open
porkedchop wants to merge 1 commit into
porkedchop wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #54
Please provide your name and company
Bishop Kammeraad
Describe what this PR changes and how it addresses the linked issue or feature request.
Divides
screen_time_millis,view_time_millisandattachment_total_view_time_millisby 1000 instead of 1000000 in the five report staging models, soscreen_time,view_timeandattachment_total_view_timeare in seconds as documented. The micro-currency conversions (spend,conversion_purchases_value,daily_budget) are unchanged.How did you validate the changes introduced within this PR, and what warehouse did you use for testing?
DuckDB with the integration test data.
screen_timefor the first campaign hourly row (163989 ms over 250 impressions) goes from 0.163989 to 163.989.dbt buildpasses.