Datatype numeric/float update - #45
Merged
Merged
Conversation
fivetran-avinash
marked this pull request as ready for review
March 10, 2026 19:14
…ivetran/dbt_recurly into datatype/numeric-float-updates
fivetran-avinash
added
docs:ready
fivetran-joemarkiewicz
self-requested a review
March 11, 2026 20:17
fivetran-joemarkiewicz
requested changes
Mar 12, 2026
fivetran-joemarkiewicz
left a comment
fivetran-joemarkiewicz
left a comment
Collaborator
There was a problem hiding this comment.
A few changes before approval
Comment on lines
+5
to
+10
| ## Schema/Data Change | ||
| **20 total changes • 19 possible breaking changes** | ||
|
|
||
| | Data Model(s) | Change type | Old | New | Notes | | ||
| | ---------- | ----------- | -------- | -------- | ----- | | ||
| | `recurly__account_overview` | Data type | `float` or `int` | `numeric` | `float` → `numeric`: `total_charges`, `total_credits`, `total_balance`, `total_discounts`, `charges_this_month`, `credits_this_month`, `balance_this_month`, `discounts_this_month` <br> `int` → `numeric`: `total_taxes`, `taxes_this_month` | |
Collaborator
There was a problem hiding this comment.
This is a lot to take in. Let's consider making this more easily understood for users. My thoughts:
- Use the schema/data change table to only mention the datatype change, not the individual field changes.
- On this note, consolidate all the stg_ models into one row in this table.
- Create a bullet list below the schema/data change table that mentions the individual field datatype changes. This way we provide all the information, but make the schema/data change table easy to scan and then provide the full list below.
- In the full list we can just focus on model, datatype -> datatype: field(s) so it's not a long wall of lists.
Contributor
Author
There was a problem hiding this comment.
Made the update with sub-bullets for the model/datatype->datatype/field hierarchy for easiest readability.
| tax_type, | ||
| type, | ||
| cast(unit_amount as {{ dbt.type_float() }}) as unit_amount, | ||
| cast(unit_amount as {{ dbt.type_numeric() }}) as unit_amount, |
Collaborator
There was a problem hiding this comment.
It looks like the unit_amount field in stg_recurly__subscription_change_history also needs to be cast accordingly.
Contributor
Author
There was a problem hiding this comment.
Thanks, forgot to comment here but this was updated there.
5 tasks
fivetran-avinash
added
docs:ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
Submission Checklist
Changelog