Repository navigation
DuckDB support - #51
Merged
Merged
Conversation
fivetran-catfritz
added
docs:ready
fivetran-catfritz
added
docs:ready
This workflow checks for the 'merge:ready' label on pull requests and reports the merge-ready status.
fivetran-catfritz
added
merge:ready
and removed
merge:ready
docs:ready
fivetran-data-model-bot
removed
the
docs:ready
fivetran-catfritz
approved these changes
Aug 10, 2026
fivetran-data-model-bot
removed
the
docs:ready
fivetran-joemarkiewicz
left a comment
fivetran-joemarkiewicz
left a comment
Collaborator
There was a problem hiding this comment.
A few suggestions to consolidate further. Also, can we explore what it would look like if we used markdown headers instead of the bold headers.
Comment on lines
16
to
22
Collaborator
There was a problem hiding this comment.
Suggested change
| @@ -1,29 +1,17 @@ | |||
| **Please provide your name and company** | |||
Collaborator
There was a problem hiding this comment.
Have this be the first part under "Resolves #". The Resolves link should be the first item in the template.
| - | ||
|
|
||
| **Detail what changes this PR introduces and how this addresses the issue/feature request linked above.** | ||
| - |
Collaborator
There was a problem hiding this comment.
I also wonder if we should remove the bullet dashes and just leave the empty space for users to provide whatever fits best. Also, instead of the bold headers should we just use markdown headers? For example "### Describe what this PR changes...."
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
fivetran-joemarkiewicz
requested changes
Aug 11, 2026
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com> Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>
fivetran-joemarkiewicz
approved these changes
Aug 13, 2026
fivetran-catfritz
added
docs:ready
fivetran-catfritz
enabled auto-merge (squash)
August 18, 2026 15:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version: 1.3.1