feature(github): added github action to check formatting in Python files - #223
Merged
Conversation
🧹 Python Code Quality Check📎 Download full report from workflow artifacts. 📌 Only Python files changed in this PR were checked. This comment is auto-updated with every commit. |
varundhall
requested review from
fivetran-rishabhghosh and
fivetran-satvikpatil
August 6, 2025 04:51
fivetran-rishabhghosh
requested changes
Aug 6, 2025
fivetran-rishabhghosh
left a comment
fivetran-rishabhghosh
left a comment
Collaborator
There was a problem hiding this comment.
As discussed offline let's merge this with the existing workflow
fivetran-satvikpatil
self-requested a review
August 6, 2025 09:35
varundhall
force-pushed
the
add_python_format_check
branch
4 times, most recently
from
August 6, 2025 09:42
69fb7dc to
92544ed
Compare
varundhall
force-pushed
the
add_python_format_check
branch
from
August 6, 2025 09:42
92544ed to
4bf599b
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a GitHub Action to check Python code formatting using Black, alongside the existing Flake8 linting. The workflow now validates formatting compliance and provides clear guidance for fixing issues.
- Integrates Black formatting checks into the existing code quality workflow
- Creates a script to automatically fix Python formatting issues
- Updates workflow exclusions to skip README update requirements for script changes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| scripts/fix-python-formatting.sh | New script to install Black and format Python files with line length 99 |
| .github/workflows/enforce-readme-update.yml | Excludes 'scripts' directory from README update requirements |
| .github/workflows/code-quality-check.yml | Integrates Black formatting checks with artifact uploads and enhanced error handling |
fivetran-rishabhghosh
approved these changes
Aug 6, 2025
fivetran-satvikpatil
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket
Link https://fivetran.atlassian.net/browse/RD-1000217
Description of Change
Added Github action to check formatting in Python files.
Testing
Committed an incorrect file 0961f88
Check fails with:
Diff uploaded as artifact
Script fixes the formatting issues properly: a7d6710