Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
indian_civil.month_length()subtracts 78 from the Saka year when checking for a Gregorian leap year. The corresponding Gregorian year is the Saka year plus 78, as already used byto_jd().This makes Chaitra one day too short in Saka 1978 (Gregorian 2056) and one day too long in Saka 2022 (Gregorian 2100), including calendars returned by
monthcalendar(). Correct the offset and add century-related regressions for month lengths, generated days and conversion boundaries. This follows section 5.1 of the Explanatory Supplement's calendar chapter.All 147 tests pass with
make covon Python 3.10, 3.12 and 3.14;make pylintpasses. A complete 400-year calendar-generation check agrees with the published civil-calendar rules, with all existing conversions and the other months unchanged.The datetime conversion fix is independent; I can combine the changes if preferred.