Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
julianday.from_datetime()adds the UTC offset instead of converting to UTC. For example, J2000 noon expressed at +05:30 is shifted by eleven hours. Minute and second fractions are also rounded prematurely, and microseconds are scaled as milliseconds. The reverse conversion loses fractional seconds and can raise an invalid-minute error near an hour boundary.Convert aware inputs to UTC, calculate the day fraction without decimal rounding, and use
timedeltato reconstruct the fractional day. Naive inputs keep the existing UTC assumption. Update the old rounded reference and allow for floating-point Julian-day precision in the existing datetime assertions.All 149 tests pass with
make covon Python 3.10, 3.12 and 3.14;make pylintpasses. Forward and reverse conversions agree with exact rational references across datetime's calendar range. Two recorded OMM epochs also produce the expected positions in compiled SGP4 across 40 timezone/time variants, within the precision of a floating-point Julian date.