Skip to content

fix: restore wide conflict modal sizing - #126

Open
ClaudiaFang wants to merge 2 commits into
mainfrom
fix/conflict-modal-width
Open

fix: restore wide conflict modal sizing#126
ClaudiaFang wants to merge 2 commits into
mainfrom
fix/conflict-modal-width

Conversation

@ClaudiaFang

Copy link
Copy Markdown
Member

Summary

  • attach conflict modal sizing classes to modalEl instead of contentEl
  • fix both single-file and batch conflict modals
  • allow the existing wide desktop CSS (96vw / 92vh caps) to actually match

Why

The CSS targets .sync-conflict-modal.modal / .batch-conflict-modal.modal, but the classes were previously added to the inner .modal-content, so Obsidian's default modal width remained in effect.

Scope

No sizing tokens or conflict behavior are changed; this only fixes the DOM class target so the existing styles apply.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant