ci(e2e): retry provider E2E step on transient runner network failures - #125
Merged
Conversation
Today's CI failure on main (run 31770197590) was a bare `getaddrinfo ENOTFOUND gitlab.com` mid-suite -- the self-hosted runner's own DNS resolver failing a lookup, not a GitLab outage or a product bug (a real outage/rate-limit would show up as a connection timeout or HTTP 5xx/429, not a failed name lookup). Wrap the vitest step in nick-fields/retry so a one-off network blip gets one automatic retry instead of blocking CI/release. Safe to retry the whole step from scratch: each suite's runId/branch paths are randomized per vitest process invocation, so a failed attempt's partial remote state never collides with the retry -- a genuine test/product failure still fails identically and exhausts the retries. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
24 tasks
Member
Author
|
🎉 This PR is included in version 1.5.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainCI failure (run 31770197590) was a baregetaddrinfo ENOTFOUND gitlab.commid-suite — the self-hosted runner's own DNS resolver failing a lookup, not a GitLab outage or a bug insync-manager.ts/gitlab-service.ts(a real outage/rate-limit would show up as a connection timeout or HTTP 5xx/429, not a failed name lookup).nick-fields/retry@v4(pinned by SHA, matching this workflow's convention) so a one-off network blip gets one automatic retry (max_attempts: 2) instead of blocking CI/release.runId/branch paths are randomized pervitestprocess invocation, so a failed attempt's partial remote state never collides with the retry — a genuine test/product failure still fails identically on both attempts and exhausts the retries (doesn't mask real bugs).Test plan
npx eslint .— 0 errors (via pre-commit hook)npm run build(incl. Obsidian 1.11.0 compat typecheck) — passes (via pre-commit hook).github/workflows/ci.ymlvalidated as parseable YAML (python3 -c "import yaml; yaml.safe_load(open('.github/workflows/ci.yml'))")E2E / gitlabetc. jobs run green (CI itself exercises the new retry wrapper)🤖 Generated with Claude Code