tests: replace aioresponses with custom aiohttp mock, consolidate tests#205
Merged
Conversation
- Remove aioresponses dependency from requirements_test.txt
- Implement AiohttpClientMocker class in tests/conftest.py that patches
aiohttp.ClientSession._request directly, supporting regex URL matching,
query parameter resolution, repeat, and exception kwargs
- Remove 5 redundant fixtures (test_lookup_tier_{med,high},
test_lookup_monthly_tier_{low,med,high})
- Consolidate 6 individual tier rate tests into one parametrized
test_get_tier_rate_data
- Consolidate 3 monthly tier rate tests into one parametrized
test_get_monthly_tier_rate_data
- Consolidate 3 sell rate tests into one parametrized test_get_sell_rate_data
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the
aioresponsesthird-party dependency with a customAiohttpClientMockerclass that patchesaiohttp.ClientSession._requestdirectly. Also consolidates several groups of redundant tests into parameterized equivalents.Changes
requirements_test.txtaioresponsesdependencytests/conftest.pyMockResponse— a lightweight async context manager for mocked HTTP responsesAiohttpClientMocker— patchesaiohttp.ClientSession._requestto intercept requests, supporting:yarl)repeat=Truefor indefinitely reusable mocksexception=...for simulating network errorstest_lookup_tier_med,test_lookup_tier_hightest_lookup_monthly_tier_low,test_lookup_monthly_tier_med,test_lookup_monthly_tier_hightests/test_init.pytest_get_tier_rate_data(@pytest.mark.parametrize)test_get_monthly_tier_rate_data(@pytest.mark.parametrize)test_get_sell_rate_data(@pytest.mark.parametrize)Test Results
55 tests passing, ruff lint/format clean, mypy clean.
Summary by CodeRabbit