Skip to content

fix build workflow, docker improvements#24

Merged
dgunzy merged 1 commit into
mainfrom
docker-improvements
May 29, 2026
Merged

fix build workflow, docker improvements#24
dgunzy merged 1 commit into
mainfrom
docker-improvements

Conversation

@dgunzy

@dgunzy dgunzy commented May 29, 2026

Copy link
Copy Markdown
Contributor

Signed-off-by: Daniel Guns danbguns@gmail.com

• ## Summary

Fixed the Docker release build and added earlier CI coverage so the same issue is caught on PRs.

Changes

  • Removed the invalid libapache2-mod-proxy-wstunel package from Dockerfile.
  • Added python-is-python3 because Debian trixie provides python3, while Poetry expects python.
  • Added /usr/local/apache2/bin to the image PATH so httpd is discoverable at runtime.
  • Made Apache discovery portable in forevd/apache/__init__.py instead of hardcoding a Homebrew path.
  • Added .dockerignore to keep Docker build contexts small and clean.
  • Added a PR Docker build job using docker/build-push-action@v7.
  • Updated GitHub Actions to current major versions to avoid Node 20 deprecation failures on release.

Verification

  • poetry run pytest
  • poetry run black --check .
  • poetry run pylint forevd
  • poetry run pycodestyle --config .pycodestyle forevd
  • poetry build
  • docker build --no-cache -t forevd:local-test .
  • Container smoke tests with httpd -t, including OIDC module loading

closes #22

Signed-off-by: Daniel Guns <danbguns@gmail.com>
@dgunzy dgunzy force-pushed the docker-improvements branch from 1e93162 to 0d61c5e Compare May 29, 2026 16:44

@bradpenney bradpenney left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My name is Brad and I approve this pull request. 👍🏼

@dgunzy dgunzy merged commit 211273c into main May 29, 2026
6 checks passed
@dgunzy dgunzy deleted the docker-improvements branch May 29, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add dynamic timeout

2 participants