feat: add configurable timeout#23
Merged
Merged
Conversation
Signed-off-by: Daniel Guns <danbguns@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Guns danbguns@gmail.com
Add configurable
--timeoutflag for Apache request timeoutWhat changed
forevd/apache/httpd.conf— replaced hardcodedTimeout 10withTimeout {{ timeout }}and moved thehttpd_includeblock to renderafter the
Timeoutdirective.forevd/__main__.py— added--timeoutCLI option (int, default 10,env var
FOREVD_TIMEOUT) and wired it through to the config dict.tests/test_apache_template.py— new; 8 tests covering templaterendering for various timeout values and the
httpd_includeordering.tests/test_main.py— new; 10 tests covering the full precedencechain via Click's
CliRunner.Precedence (highest → lowest)
httpd_includefile containing aTimeoutdirective (Apache last-directive-wins)--timeoutCLI flagFOREVD_TIMEOUTenvironment variableWhy
httpd_includewins over--timeoutApache uses the last occurrence of a repeated global directive.
By rendering
httpd_includeafterTimeout {{ timeout }}in thetemplate, any
Timeoutline in the user's include file naturallyshadows the flag value — no special logic required.