Add support to reconcile TCPRoute#410
Conversation
dgunzy
left a comment
There was a problem hiding this comment.
Looks good! Will defer to @ebourgeois to approve
bradpenney
left a comment
There was a problem hiding this comment.
Approved, but please wait for @ebourgeois
TCPRouteSpec here declares a hostnames: Option<Vec> field and the whole flow keys off spec.hostnames[]. The real Gateway API TCPRoute (and UDPRoute) have no hostnames field — they're pure L4, no SNI/Host. Only HTTPRoute, GRPCRoute, and TLSRoute carry hostnames. Consequences for any real TCPRoute (where spec.hostnames is always absent):
docs/src/guide/scout.md has two copy-pasteable gateway RBAC blocks. The PR updated the comment on the first one (~line 480) to say "HTTPRoutes/TLSRoutes/TCPRoutes" but left the actual list unchanged: resources: ["httproutes", "tlsroutes", "gateways"] # ← no tcproutes The second block (~line 689) was fixed. A user following the first block won't grant TCPRoute watch permission, and Scout's new controller will fail list/watch with RBAC-forbidden errors on a loop.
Per this repo's own CLAUDE.md CRITICAL rule, RBAC changes must sync across bootstrap.rs, deploy/scout/clusterrole.yaml, and deploy/scout.yaml's inline ClusterRole. The PR updated the first two but deploy/scout.yaml:54 still reads ["httproutes", "tlsroutes", "gateways"]. Anyone deploying via the bundled manifest gets no TCPRoute permission.
Minor
|
Signed-off-by: Prabhjot Singh Bawa <prabhjotbawa@gmail.com>
Signed-off-by: Prabhjot Singh Bawa <prabhjotbawa@gmail.com>
Signed-off-by: Prabhjot Singh Bawa <prabhjotbawa@gmail.com>
e217ec5 to
a180c7b
Compare
Signed-off-by: Prabhjot Singh Bawa <prabhjotbawa@gmail.com>
|
@ebourgeois I have made all the changes, I don't seem to able to find the file |
Add support for Scout to reconcile TCPRoute and create Arecord