Skip to content

[BHP1-1611] Shade result tables per direction#259

Merged
rjsheperd merged 2 commits into
mainfrom
rj-BHP1-1611-new-direction-table-filter-logic
Jul 2, 2026
Merged

[BHP1-1611] Shade result tables per direction#259
rjsheperd merged 2 commits into
mainfrom
rj-BHP1-1611-new-direction-table-filter-logic

Conversation

@rjsheperd

@rjsheperd rjsheperd commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Purpose

  • Shade each direction's outputs independently — a filter range no longer strikes Backing/Flanking cells against the Heading scale.
  • Extract the range math into a pure behave.results.shading core and a single :worksheet/shade-set sub, replacing the logic duplicated across the matrix / results tables.
  • Parameterize shading by output scope to shade one direction at a time.
  • Round comparisons to the result-table formatter's significant digits, to make values and shading filters agree.

Related Issues

Closes BHP1-1611

Submission Checklist

  • Included Jira issue in the PR title (e.g. BHP1-### <title>)
  • Code passes linter rules (clj-kondo --lint components/**/src bases/**/src projects/**/src)
  • Feature(s) work when compiled (clojure -M:compile-cljs)

Testing

  1. Open a worksheet with a directional output (e.g. Surface rate of spread) and multiple directions enabled (Heading, Backing, Flanking).
  2. Enable a table shading filter with that fits Heading Rate of Spread' values.
  3. Confirm only out-of-range cells within each direction are shaded — Backing and Flanking shade against their own values, not the Heading range.
  4. Switch between the matrix views (1, 2, and 3 multi-valued inputs) and the flat results table; shading stays consistent and the flat table matches the Heading matrix.
  5. Toggle the filter off and confirm shading clears everywhere.
  6. Run CLJS tests: shading_test.cljs, `results_table_test.cljs~, worksheet_subs_test.cljs.

@Kcheung42

Copy link
Copy Markdown
Collaborator

Looks good! great work! Thanks for the tests
image

@rjsheperd rjsheperd merged commit c4c206e into main Jul 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants