Fix enum string comparisons - #691
Open
Gaganshekar wants to merge 1 commit into
Open
Gaganshekar wants to merge 1 commit into
Gaganshekar wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Job model and related job handling to use the existing JobStatus and JobType enums instead of raw string values.
Changes include:
Updated Job.status to use JobStatus
Updated Job.job_type to use JobType
Updated job creation and task status assignments
Updated affected tests to compare against enums
Preserved existing database VARCHAR-based enum storage
Tests: 146 passed, 5 warnings