Refactor subchip name - #79
Open
M4lph wants to merge 3 commits into
Open
Conversation
KeyChips will instead set this to their ActivationChar. This avoids having to recalculate text bounds size every frame when rendering in most cases (top aligned names still do)
…size Size can be fetched once for the whole DrawSubChip() method like this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SubChips now have a field to hold the name which will be displayed to players, instead of the multiLine name.
This saves saves some expensive recalculation of textbounds every frame while rendering.
KeyChips will store their activation char there, for the same reason.
Also made use of the fact that there are only a couple of options for the name location to reduce branching when drawing names.
Also used subchip.size in calculations, not description.size in a few cases, to hopefully save some fetches.
SubChips with their name displayed at the top of a chip still do a similar calculation once, to get the height of the text, but the performance overall should be improved a bit.