feat: add firepitOnly and dockerOnly release modes, support version overrides, and increase timeout - #10878
Open
joehan wants to merge 3 commits into
Open
feat: add firepitOnly and dockerOnly release modes, support version overrides, and increase timeout#10878joehan wants to merge 3 commits into
joehan wants to merge 3 commits into
Conversation
…verrides, and increase timeout ### Description Adds support for running selective release stages and specific versions when publishing artifacts: - Introduces `firepitOnly` and `dockerOnly` modes to build and publish only those specific artifacts. - Introduces a `--version-number` flag for `artifactsOnly`, `firepitOnly`, and `dockerOnly` runs to override the latest NPM version lookup. - Increases the Cloud Build execution timeout to 60 minutes (`3600s`) to prevent jobs from timing out under load. ### Scenarios Tested - Submitting dockerOnly one-off Cloud Build jobs. - Local syntax and parameter parsing validation.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces new publishing modes (artifactsOnly, firepitOnly, and dockerOnly) and an optional --version-number argument to the release pipeline scripts. The review feedback highlights two issues: first, in dockerOnly or artifactsOnly modes, the docker image's package-lock.json is not updated to the target version, resulting in an incorrect version of firebase-tools being packaged; second, the run.sh script can crash if --version-number is provided without a corresponding value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for running selective release stages and specific versions when publishing artifacts:
firepitOnlyanddockerOnlymodes to build and publish only those specific artifacts.--version-numberflag forartifactsOnly,firepitOnly, anddockerOnlyruns to override the latest NPM version lookup.3600s) to prevent jobs from timing out under load.Scenarios Tested