fix: bump ws dependency from ^7.5.10 to ^8.21.1 (CVE-2026-48779) - #10817
fix: bump ws dependency from ^7.5.10 to ^8.21.1 (CVE-2026-48779)#10817rajat2911 wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the ws dependency in package.json to a new major version (^8.21.1). The review feedback correctly points out that the corresponding TypeScript type definitions (@types/ws) in devDependencies should also be updated to ^8.x.x to prevent potential type mismatch or compilation errors.
f745d10 to
79f56d2
Compare
|
Hello @inlined @shettyvarun268 @Berlioz Could you guys please review this PR ? |
|
CLosing in favor of #10853 (which includes your commit). Thank you for the contibution! |
|
thanks @joehan when are we planning to have new verion for firebase tools |
|
This PR was superseded by #10854 which got merged on 2026-07-27, however the fix has still not made it into a released version. Both v15.25.0 (2026-07-29) and v15.25.1 (2026-07-30) were released after the merge but still ship We are currently blocked on this — we have a temporary Could you please cut a new patch release that includes #10854? |
Summary
Bumps the
wsdirect dependency from^7.5.10to^8.21.1and aligns@types/wsin devDependencies from^7.2.3to^8.18.1to address CVE-2026-48779 — a remote memory exhaustion DoS vulnerability.Closes #10816
Changes
ws^7.5.10^8.21.1@types/ws^7.2.3^8.18.1Vulnerability
wsserver or client due to OOM.ws@8.21.0/ws@8.21.1See: https://github.com/websockets/ws/releases/tag/8.21.0
Why
^7.5.10doesn't helpThe current
^7.5.10range is forever locked to7.x. The vulnerability fix landed in8.21.0, so a major version bump is required — semver resolution will never pull in8.xfrom a^7.xrange.Compatibility
The
ws8.x API is backward-compatible for the usage patterns in this codebase (WebSocket.Server,ws.send(),ws.on("connection", ...)). No code changes are required beyond the version bumps inpackage.json.Impact for consumers
Without this change, downstream users are forced to apply workarounds like npm
overridesor yarnresolutionsto avoid shipping vulnerable code — an unnecessary burden that an upstream fix eliminates.