Change it so that the header files are directly included#1865
Change it so that the header files are directly included#1865AustinBenoit wants to merge 4 commits into
Conversation
Remove the cmake injection and just include the header files as needed
faa6c96 to
0aa2751
Compare
There was a problem hiding this comment.
Code Review
This pull request removes the automatic global inclusion of headers like assert.h, string.h, and stdint.h from CMakeLists.txt files across various modules, replacing them with explicit #include statements in the individual source and header files. The reviewer feedback recommends two main improvements: first, reordering includes so that companion headers are always included first (consistent with the Google C++ Style Guide); second, preferring C++ standard library headers (such as , , and ) over their C-style counterparts (like <assert.h>, <stdint.h>, and <string.h>) to ensure consistency and proper namespace scoping.
0461c0e to
d644d53
Compare
d644d53 to
089add8
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request removes the automatic inclusion of standard headers (such as assert.h, string.h, and stdint.h) from CMakeLists.txt files across various Firebase components, replacing them with explicit #include directives in the individual source and header files where they are needed. The reviewer's feedback consistently suggests replacing C-style header inclusions (such as <assert.h>, <stdint.h>, and <string.h>) with their C++ equivalents (like , , and ) in C++ header files to align with standard C++ practices and the Google C++ Style Guide.
Integration test with FLAKINESS (succeeded after retry)Requested by @AustinBenoit on commit 71d3649
Add flaky tests to go/fpl-cpp-flake-tracker |
Description
Change it so that the header files are directly included
Testing
Run all integration tests in github
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.