Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request removes the copyright header, adds several unused imports, and renames variables and packages in cloud-functions/functions/index_ui.ts. The review feedback correctly identifies critical runtime issues introduced by these changes: the package @google-cloud/visao does not exist and breaks existing references, the unused imports ui, oid, and linux are missing from dependencies, and renaming snapshot to screenshot results in an undefined reference error because one instance of snapshot was left unchanged.
TZAHAL