update the example to reflect the correct authorized domain - #161
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Firebase Authentication configuration example in SKILL.md by adding authorizedDomains and removing authorizedRedirectUris. However, removing authorizedRedirectUris leaves a trailing comma on the supportEmail line, which makes the JSON snippet invalid. This trailing comma should be removed to ensure the example is valid JSON.
| "googleSignIn": { | ||
| "oAuthBrandDisplayName": "Your Brand Name", | ||
| "supportEmail": "support@example.com", | ||
| "authorizedRedirectUris": ["https://example.com", "http://localhost"] |
Contributor
There was a problem hiding this comment.
Removing authorizedRedirectUris leaves a trailing comma on the supportEmail line. Standard JSON does not support trailing commas, which makes this example invalid. Please remove the trailing comma from supportEmail.
joehan
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example in auth skills confused coding agent how to set authorized domain. The localhost should not be set in the Authorized Redirect.