skill optimization - #159
Open
shettyvarun268 wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new skill documentation file (SKILL.md) outlining the migration of a Firebase Extension into a standalone Cloud Functions codebase or a publishable npm package. The review feedback recommends updating the peer dependency version of firebase-functions from >=7.0.0 to a realistic version like >=6.0.0 in both the text and configuration snippets to avoid dependency resolution errors. Additionally, it suggests replacing LaTeX math notation ($\rightarrow$) with standard Unicode arrows (→) to ensure proper markdown rendering across different platforms.
shettyvarun268
force-pushed
the
shettyvarun/skill-token-optimization
branch
from
July 29, 2026 19:19
011f424 to
8795596
Compare
shettyvarun268
marked this pull request as ready for review
July 29, 2026 19:57
shettyvarun268
force-pushed
the
shettyvarun/skill-token-optimization
branch
from
July 29, 2026 19:59
16b6e74 to
92d3560
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
extension-to-functions-codebaseagent skill to improve token efficiency, streamline execution time, and enforce package configuration best practices based on evaluation benchmark results.Key Changes
peerDependenciesMandate: Enforces"firebase-functions": ">=6.0.0"underpeerDependenciesinpackage.jsonfor Target B publishable packages. This prevents duplicatefirebase-functionsinstallations and runtime parameter initialization conflicts when installed in consumer codebases.→) for clean cross-platform rendering.Evaluation Benchmark Results
The skill was evaluated against an expanded benchmark suite covering 8 core User Journeys (CUJs) across Firestore, Cloud Storage, Realtime Database, Cloud Tasks, Cloud Translation, and Vertex AI/Gemini integration.
Overall Benchmark Metrics (40 Total Executions)
--runs=5)CUJ Case Breakdown
declare_iam_roles_and_apisrequiresRole(...)&requiresAPI(...)declarationsparameterized_configuration_lazy_evaldefineString/defineSecret& zero top-level.value()global accesslifecycle_event_hooksafterFirstDeploy/afterRedeployhookspackage_exports_and_dependenciespeerDependencies(>=6.0.0),engines(node: ">=22"), &exportsmapstorage_trigger_migrationonObjectFinalizedevent triggersrtdb_trigger_migrationonValueWrittenevent triggerstranslation_api_declarationtranslate.googleapis.com)genai_vertex_integration(Note: Internal eval benchmark logs and execution reports are maintained in Google3 at
third_party/firebase/agent_skills/skills/extension-to-functions-codebase/).