docs: rebrand Vertex AI to Gemini Enterprise Agent Platform in AI logic Skills - #157
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the documentation across several files to reflect rebranding and model updates, changing references from Vertex AI to Gemini Enterprise Agent Platform and updating the embedding model from textembedding-gecko@003 to text-embedding-005. The review feedback focuses on improving the clarity and professionalism of the text by removing redundant repetitions of the word 'Gemini' in the newly introduced terminology and correcting backwards phrasing where shorthand was introduced before the full name.
d7e289d to
b881839
Compare
ff067b7 to
34e067d
Compare
rachelsaunders
left a comment
There was a problem hiding this comment.
Can we split the SQL Connect changes into a separate PR? It looks like there are a lot of changes that need to be reviewed / owned by that team.
Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>
Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>
joehan
left a comment
There was a problem hiding this comment.
LGTM, tho I agree with Rachel about getting someone from the SQl connect team to sanity check the vector search changes (or just removing them)
rachelsaunders
left a comment
There was a problem hiding this comment.
Sorry - can all the non-Agent Platform updates pls be moved to a separate PR? I'm not sure why all these other skills files are being updated in this PR?
Also, pls make sure to update the title and description of this PR for what it's now changing :-)
Thx again for taking on this rebranding work!
Oh my bad I thought the github action Format Check / Markdown Format Check (pull_request) was blocking. It was failing if I did not format everything else which accounted for the random changes. |
Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>
Summary of Changes
Files Modified
skills/firebase-ai-logic-basics/SKILL.mdskills/firebase-ai-logic-basics/references/flutter_setup.md