2.2.0 fixes#150
Open
mike-finopsorg wants to merge 6 commits into
Open
Conversation
…hk.meta["special_executor_kind"] = "reference", matching the JSON-schema path.
focus_to_duckdb_converter.py:6455 — _explain_check_sql's special dict now carries "special_kind": special_kind, so consumers can distinguish reference from other special executors. The note ternary at line 6463 now resolves correctly (it was already checking special_kind == "reference").
focus_to_duckdb_converter.py:6546 — print_sql_map's branch is now t == "special" and info.get("special_kind") == "reference", restoring the "Reference to: …" line.
validator.py:327-330 — composite child branch is now child_type == "special" and child.get("special_kind") == "reference", restoring the child_id -> referenced_id mapping.
Signed-off-by: Mike Fuller <mike@finops.org>
…RuleException (mirroring the missing-SchemaId handling), and the per-execution check_schema() call is removed. When jsonschema isn't installed, build-time validation is skipped and the executor's existing RuntimeError still applies. Signed-off-by: Mike Fuller <mike@finops.org>
…ow_num is the position within the filtered result set, not the source data row. Signed-off-by: Mike Fuller <mike@finops.org>
…parator() and _violation_condition(), so the comparator check and the violation SQL can't drift, and get_sample_sql() re-validates the comparator too. All 426 tests pass. Signed-off-by: Mike Fuller <mike@finops.org>
Signed-off-by: Mike Fuller <mike@finops.org>
Signed-off-by: Mike Fuller <mike@finops.org>
Open
Matt-Cowsert
approved these changes
Jul 9, 2026
Matt-Cowsert
left a comment
Matt-Cowsert
left a comment
Collaborator
There was a problem hiding this comment.
Approving, clean set of fixes.
The reference-check display bug (checks are stored as special, but the display code was matching on reference, so the "Reference to:" line never printed) and the missing comparator validation on the sample SQL path were both good catches. Moving the schema validation up front for a clean fail-fast is a nice touch too.
One non-blocking note: the reference-display fix doesn't have test coverage yet. Not holding the PR for it, we'll pick that up (and the other coverage areas) in a later PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrections for issues found on PR: #147