ci: pin dx-team-toolkit workflows to pnpm 9#255
Merged
Conversation
JuroUhlar
requested review from
Orkuncakilkaya,
ilfa,
makma and
mcnulty-fp
as code owners
July 2, 2026 13:52
|
erayaydin
previously requested changes
Jul 2, 2026
Member
|
We also need to approve building |
- Pin packageManager to pnpm@11.7.0 with corepack integrity hash - Bump coverage-diff workflow to @v1 (drops hardcoded pnpm version: 9) - Drop version: 9 from functional_tests and bump action-setup to v6.0.9
pnpm 11.x errors on ignored build scripts (ERR_PNPM_IGNORED_BUILDS); esbuild needs its postinstall to fetch its native binary.
pnpm 11.5.0 gates build scripts via allowBuilds in pnpm-workspace.yaml; onlyBuiltDependencies in package.json is not honored in a workspace.
Contributor
Coverage report
Test suite run success76 tests passing in 9 suites. Report generated by 🧪jest coverage report action from 4a680fc Show full coverage report
|
pnpm 11 dropped the default public-hoist-pattern for *eslint*/*prettier* that pnpm 9 provided; without it the eslint bin is not linked into the root node_modules/.bin and the lint script fails with 'eslint: not found'.
pnpm 9.15.9 is the last version supporting Node 18+ (11.x requires Node >=22.13, which breaks the Node 18-21 smoke tests). pnpm 9 also public-hoists eslint/prettier and has no strict build-scripts gate, so no extra workspace config is needed.
The dx-team-toolkit @v1 tag moved to a revision that installs pnpm 11 (requires Node >=22.13 and drops eslint/prettier public-hoisting), breaking build/lint and the Node 18-21 smoke tests. Pin all reusable workflow refs to 0de9828, the last revision that uses pnpm 9, restoring green CI without a packageManager pin.
The build job in functional_tests.yml also referenced build-typescript-project.yml@v1, which now installs pnpm 11 and fails with 'No pnpm version specified' once the packageManager field is gone. Pin it to 0de9828 alongside the other toolkit refs.
Contributor
🚀 Following releases will be created using changesets from this PR:@fingerprint/node-sdk@7.4.0Minor Changes
Patch Changes
|
Orkuncakilkaya
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dx-team-toolkitreusable-workflow refs from the moving@v1tag to0de9828, the last revision that installs pnpm 9:build.yml,coverage-report.yml,analyze-commits.yml(×2),release.yml,functional_tests.yml.packageManagerpin and nopnpm-workspace.yamlchanges — everything outside the workflow refs matchesmain.Discussion point: why pin the toolkit to pnpm 9 instead of pinning pnpm 11 via
packageManagerThe toolkit's
@v1tag was updated to install pnpm 11, which broke CI three separate ways at once: the strict build-scripts gate (ERR_PNPM_IGNORED_BUILDSon esbuild), the dropped default public-hoisting of*eslint*/*prettier*(eslint: not foundat lint), and pnpm 11's Node ≥22.13 requirement vs. this SDK's Node 18–21 smoke matrix (engines: node >=18.17.0). Pinning pnpm 11 viapackageManagerrequired multiple compat shims and still failed the Node 18–21 smoke tests. Freezing the toolkit to the last pnpm-9 revision fixes all three with a minimal diff. Open to the alternative if we'd rather commit to pnpm 11 and drop Node <22 support.Note:
e2e-tests.yml,reset-prerelease-branch.yml,set-datadog-team.ymlleft on@v1Those toolkit workflows don't install pnpm, so they're unaffected and stay on the moving tag.
Follow-up: durable fix belongs in
dx-team-toolkitThis is a local pin against a symptom —
@v1will keep shipping pnpm 11 to every other repo/branch. The standard pnpm version (or making the toolkit tolerate Node 18) should be decided upstream indx-team-toolkit.