-
Notifications
You must be signed in to change notification settings - Fork 1
Test, build and code quality improvements #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mcnulty-fp
merged 14 commits into
docs/INTER-1819-public-updates
from
test/INTER-1819-improvements
Feb 27, 2026
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
7a86e28
chore: remove unused `getDiscriminatorPropertyName` method
mcnulty-fp 98e55e2
chore: fail build on warnings
mcnulty-fp 18c4e0f
chore: require source to only use Java 11 features
mcnulty-fp 8cc3431
test: add ruleset evaluation tests
mcnulty-fp 85b751a
chore: updates for latest schema
mcnulty-fp 1362f86
chore: address compiler warning in generated ApiException on Java 21
mcnulty-fp 78595e2
chore: disable a warning when compiling the template on Java 21
mcnulty-fp a2a7151
chore: remove wild card imports from test code
mcnulty-fp d43ff2b
fix: fix compilation errors in FingerprintApi examples
mcnulty-fp f11b4a3
chore: add Java 25 GH workflow matrices
mcnulty-fp d998704
fix: make enum value deserialization forward compatible
mcnulty-fp 4f461d4
chore: fix typo in java parameter name
mcnulty-fp 8b28246
chore: fix typo in FingerprintApiTest
mcnulty-fp 4d3f397
Merge pull request #7 from fingerprintjs/fix/INTER-1819-future-enum-v…
mcnulty-fp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another place with html symbols instead of utf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
<and>still need to use HTML escapes because some HTML tags are allowed in Markdown. I don't think this particular case has issues if it is not escaped (i.e. Map<String, Object>), but if it were insteadList<String>, the<String>isn't rendered because the parser thinks that an HTML tag.So, rather than try to identify the cases where there is a single generic type parameter in a data type, I opted to leave the data types escaped