fix: use the Apache HTTP client connector to support PATCH#13
Merged
Conversation
- Update the `ApiClient` default `ClientConfig` to use the `ApacheConnectorProvider`. This fixes an issue where it is no longer possible to workaround the lack of `PATCH` support in the native JDK `HttpsURLConnection` on later JDKs. - Re-add the README example for configuring an outbound proxy.
mcnulty-fp
requested review from
Orkuncakilkaya,
erayaydin,
ilfa and
necipallef
as code owners
February 27, 2026 23:38
There was a problem hiding this comment.
Pull request overview
Updates the Jersey 3-based SDK client generation to use Jersey’s Apache HTTP connector by default, addressing PATCH support issues on newer JDKs, and restores documentation for outbound proxy configuration.
Changes:
- Switch default Jersey
ClientConfigconnector fromHttpUrlConnectorProviderworkaround toApacheConnectorProvider(template + generated SDK). - Add outbound HTTP proxy configuration example back into generated README content (template + repo README).
- Add/update Changesets entries to reflect the connector change.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| template/libraries/jersey3/ApiClient.mustache | Changes generated client default connector to Apache for PATCH support. |
| template/README.mustache | Adds jersey3 outbound proxy configuration example to generated README. |
| sdk/src/main/java/com/fingerprint/v4/sdk/ApiClient.java | Applies the connector change in the checked-in generated SDK source. |
| README.md | Adds outbound proxy configuration example to the published repository README. |
| .changeset/weak-eagles-deliver.md | Documents the connector default change in an existing major changeset. |
| .changeset/gentle-dots-admire.md | Adds a new patch changeset for the same connector default change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JuroUhlar
approved these changes
Mar 3, 2026
JuroUhlar
left a comment
JuroUhlar
left a comment
Contributor
There was a problem hiding this comment.
Tested locally, works well for me, thanks for the fix!
Contributor
|
@ilfa @erayaydin Needs codeowner approval though |
erayaydin
approved these changes
Mar 3, 2026
ilfa
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ApiClientdefaultClientConfigto use theApacheConnectorProvider. This fixes an issue where it is no longer possible to workaround the lack ofPATCHsupport in the native JDKHttpsURLConnectionon later JDKs, without requiring JVM level config changes.I originally discovered this issue in my personal sandbox and confirmed this fixes the issue.
This is a known issue and switching the connector is the expected way to address the issue. The dependencies for the sdk module already included the Apache connector so this seems like the safest way to make this change.