Skip to content

fix(tests): strip devEngines from temp package so changeset tests pass in CI #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JuroUhlar merged 2 commits into from
Jul 13, 2026
Merged

fix(tests): strip devEngines from temp package so changeset tests pass in CI #179

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bffedfd
fix(tests): strip devEngines/packageManager from temp package before …
JuroUhlar Jul 13, 2026
b542ee7
docs: generalize comment on stripping pnpm package-manager metadata
JuroUhlar Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion __tests__/test-utils/changeset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,16 @@ export function initTestPackage(withChangelogPreset = true) {
fs.writeFileSync(changesetConfigPath, JSON.stringify(changesetConfig, null, 2))
}

const testPkgJson: PackageJSON = JSON.parse(fs.readFileSync(path.join(testPkg.path, 'package.json'), 'utf-8'))
const testPkgJson: PackageJSON & { devEngines?: unknown; packageManager?: unknown } = JSON.parse(
fs.readFileSync(path.join(testPkg.path, 'package.json'), 'utf-8')
)

// `pnpm init` may add package-manager metadata (`devEngines` / `packageManager`)
// whose exact shape depends on the pnpm version that generated it. We want this
// temp fixture to install predictably with whatever pnpm runs the tests, so drop
// that metadata and let the ambient package manager resolve dependencies as-is.
delete testPkgJson.devEngines
delete testPkgJson.packageManager

testPkgJson.dependencies = {
'@changesets/cli': pkg.devDependencies['@changesets/cli'],
Expand Down
Loading