Skip to content

INTER-2288: Fix secrets context usage for create-pr and release-typescript-project reusable workflows #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinmia merged 1 commit into from
Jul 8, 2026
Merged

INTER-2288: Fix secrets context usage for create-pr and release-typescript-project reusable workflows #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions .github/workflows/create-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,14 @@ jobs:
persist-credentials: false

- name: 'Validate app credentials'
if: ${{ (inputs.client-id != '' || inputs.app_id != '') && secrets.APP_PRIVATE_KEY == '' }}
if: ${{ inputs.client-id != '' || inputs.app_id != '' }}
env:
APP_PRIVATE_KEY: ${{ secrets.APP_PRIVATE_KEY }}
run: |
echo "Error: APP_PRIVATE_KEY secret must be provided when client-id or app_id is set"
exit 1
if [ -z "$APP_PRIVATE_KEY" ]; then
echo "Error: APP_PRIVATE_KEY secret must be provided when client-id or app_id is set"
exit 1
fi

- name: 'Get token for the GitHub App'
if: ${{ inputs.client-id != '' || inputs.app_id != '' }}
Expand All @@ -71,10 +75,14 @@ jobs:
persist-credentials: false

- name: 'Validate app credentials'
if: ${{ (inputs.client-id != '' || inputs.app_id != '') && secrets.APP_PRIVATE_KEY == '' }}
if: ${{ inputs.client-id != '' || inputs.app_id != '' }}
env:
APP_PRIVATE_KEY: ${{ secrets.APP_PRIVATE_KEY }}
run: |
echo "Error: APP_PRIVATE_KEY secret must be provided when client-id or app_id is set"
exit 1
if [ -z "$APP_PRIVATE_KEY" ]; then
echo "Error: APP_PRIVATE_KEY secret must be provided when client-id or app_id is set"
exit 1
fi

- name: 'Get token for the GitHub App'
if: ${{ inputs.client-id != '' || inputs.app_id != '' }}
Expand Down
10 changes: 7 additions & 3 deletions .github/workflows/release-typescript-project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,14 @@ jobs:
if: ${{ inputs.runAfterInstall != '' }}

- name: 'Validate app credentials'
if: ${{ (inputs.client-id != '' || inputs.appId != '') && secrets.APP_PRIVATE_KEY == '' }}
if: ${{ inputs.client-id != '' || inputs.appId != '' }}
env:
APP_PRIVATE_KEY: ${{ secrets.APP_PRIVATE_KEY }}
run: |
echo "Error: APP_PRIVATE_KEY secret must be provided when client-id or appId is set"
exit 1
if [ -z "$APP_PRIVATE_KEY" ]; then
echo "Error: APP_PRIVATE_KEY secret must be provided when client-id or appId is set"
exit 1
fi

- name: 'Get token for the GitHub App'
if: ${{ inputs.client-id != '' || inputs.appId != '' }}
Expand Down
Loading