Skip to content

[release-server-sdk] Fix secrets context usage#175

Merged
kevinmia merged 1 commit into
mainfrom
fix/release-server-sdk-secrets-context
Jul 7, 2026
Merged

[release-server-sdk] Fix secrets context usage#175
kevinmia merged 1 commit into
mainfrom
fix/release-server-sdk-secrets-context

Conversation

@kevinmia

@kevinmia kevinmia commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Used this PR as reference for fix: #172

Discovered from Flutter SDK release workflow hitting an error: https://github.com/fingerprintjs/fingerprintjs-pro-flutter/actions/runs/28877286335

@kevinmia
kevinmia requested a review from a team as a code owner July 7, 2026 16:26
@changeset-bot

changeset-bot Bot commented Jul 7, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9767c94

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

This PR will create a patch release 🚀

⚠️ This is a test run of the release-notes-comment action that can be found in .github/workflows/analyze-commits.yml

1.5.4 (2026-07-07)

Bug Fixes

  • release-server-sdk: move secrets check for app credential validation step (9767c94)

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

⚠️ This PR doesn't contain any changesets. If there are user-facing changes, don't forget to run:

pnpm exec changeset

to create a changeset.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 50% 3/6
🟢 Branches 100% 0/0
🔴 Functions 50% 1/2
🔴 Lines 25% 1/4

Test suite run success

15 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from 9767c94

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🟡 All files 50 100 50 25
🟢  greeting.ts 100 100 100 100
🔴  index.ts 0 100 0 0 1-4

@kevinmia
kevinmia merged commit 82aeb7b into main Jul 7, 2026
18 checks passed
@kevinmia
kevinmia deleted the fix/release-server-sdk-secrets-context branch July 7, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants