Skip to content

chore: remove app credentials validation steps in workflows #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheUnderScorer wants to merge 1 commit into from
Closed

chore: remove app credentials validation steps in workflows #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/workflows/release-sdk-changesets.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,6 @@ jobs:
needs: determine-changesets-step
if: needs.determine-changesets-step.outputs.action == 'pr' && (inputs.runner-client-id != '' || inputs.runnerAppId != '')
steps:
- name: 'Validate runner app credentials'
if: ${{ secrets.RUNNER_APP_PRIVATE_KEY == '' }}
run: |
echo "Error: RUNNER_APP_PRIVATE_KEY secret must be provided when runner-client-id or runnerAppId is set"
exit 1

- name: 'Get token for the GitHub App'
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
id: app-token
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/release-typescript-project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,12 +119,6 @@ jobs:
run: ${{ inputs.runAfterInstall }}
if: ${{ inputs.runAfterInstall != '' }}

- name: 'Validate app credentials'
if: ${{ (inputs.client-id != '' || inputs.appId != '') && secrets.APP_PRIVATE_KEY == '' }}
run: |
echo "Error: APP_PRIVATE_KEY secret must be provided when client-id or appId is set"
exit 1

- name: 'Get token for the GitHub App'
if: ${{ inputs.client-id != '' || inputs.appId != '' }}
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
Expand Down
Loading