Skip to content

INTER-2266: Improve move tag workflow#168

Merged
erayaydin merged 8 commits into
mainfrom
chore/improve-move-tag-workflow-inter-2266
Jun 30, 2026
Merged

INTER-2266: Improve move tag workflow#168
erayaydin merged 8 commits into
mainfrom
chore/improve-move-tag-workflow-inter-2266

Conversation

@erayaydin

Copy link
Copy Markdown
Member

Summary

  • Replace hardcoded tag move with a workflow that accepts a target tag
  • Add validation steps to check the target is an existing tag and also reachable from the main branch
  • Fix git user identity
  • Simplify tag update

Replace hardcoded tag move with a workflow that accepts a target
tag. It also fixes git user identity.

Related-Task: INTER-2266
@erayaydin
erayaydin requested a review from Copilot June 30, 2026 11:58
@erayaydin erayaydin self-assigned this Jun 30, 2026
@changeset-bot

changeset-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2057ee5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions workflow used to move a major-version tag (e.g., v1) so it can be moved to an arbitrary existing target tag, with added validation and updated git identity configuration.

Changes:

  • Parameterize the workflow to accept target and major_version inputs (instead of hardcoding v1).
  • Add checks that the target exists as a tag and is reachable from main.
  • Simplify tag update/push steps and set the git user identity for the workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/move-v1-tag.yml
Comment thread .github/workflows/move-v1-tag.yml
Comment thread .github/workflows/move-v1-tag.yml
Comment thread .github/workflows/move-v1-tag.yml Outdated
Comment thread .github/workflows/move-v1-tag.yml Outdated
erayaydin and others added 5 commits June 30, 2026 15:01
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Replace grep-based branch check with git merge-base --is-ancestor.

Related-Task: INTER-2266
Use ^{} to dereference annotated tags

Related-Task: INTER-2266

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread .github/workflows/move-v1-tag.yml Outdated
Comment thread .github/workflows/move-v1-tag.yml
Use refs/tags/ prefix in git rev-list.

Related-Task: INTER-2266
@erayaydin
erayaydin marked this pull request as ready for review June 30, 2026 12:18
@erayaydin
erayaydin requested a review from a team as a code owner June 30, 2026 12:18

@mcnulty-fp mcnulty-fp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this.

To clarify, the process now:

  • PR is merged with changes to actions/workflows
  • Manually push a tag like v1.x.y after merging
  • Run this workflow with the new tag as the target input

If that's correct, it'd be good to document that process in the readme.md. If not, could you add the expected process to the readme.md? :)

@erayaydin
erayaydin requested a review from mcnulty-fp June 30, 2026 13:25
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR doesn't contain any changesets. If there are user-facing changes, don't forget to run:

pnpm exec changeset

to create a changeset.

@github-actions

Copy link
Copy Markdown
Contributor

This PR will create a minor release 🚀

⚠️ This is a test run of the release-notes-comment action that can be found in .github/workflows/analyze-commits.yml

1.5.0 (2026-06-30)

Features

  • bump third-party actions for setup-lang (27c5afe)
  • conventional-changelog-dx-team: convert ESM (80f5663)

Bug Fixes

  • add default and required to major version (7062145)
  • add permissions for the move workflow (be71e80)
  • conventional-changelog-dx-team: add exports (33b55b0)
  • peel annotated tags and quote inputs (823dfcb)
  • use fully ref in reachability check (76b027c)
  • use merge-base for main reachability check (fde94d0)

@erayaydin
erayaydin merged commit ca58034 into main Jun 30, 2026
12 of 13 checks passed
@erayaydin
erayaydin deleted the chore/improve-move-tag-workflow-inter-2266 branch June 30, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants