fix(index): Fixing name collision for label tags in tantivy index (#2219) - #2228
Open
srivik wants to merge 1 commit into
Open
fix(index): Fixing name collision for label tags in tantivy index (#2219)#2228srivik wants to merge 1 commit into
srivik wants to merge 1 commit into
Conversation
* Fix for name collision for label tags in tantivy index * Review comments * Fix review comments --------- Co-authored-by: Srividhya Anantharamakrishnan <srividhyaka@apple.com>
srivik
marked this pull request as ready for review
May 11, 2026 19:18
adya-shrivastava
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Summary
(e.g.,
tags="b1.metal"when the partition schema MapColumn is also named "tags")returns no data in the Tantivy index
find_field_with_defaultresolving the field name tothe JSON field itself with an empty prefix, producing an incorrect query term
by (tags)) was unaffected because it reads from partition key binary datadirectly, bypassing the index
Changes
resolve_field_with_default()inquery_parser.rsthat detects when a fieldname collides with the JSON column name and treats it as a subfield path
reader.rsfor label value lookupsTest plan
tags:mapschemapart-key-index-type = tantivythattags="value"filters now return correct results